Re: [Xen-devel] [PATCH v4 15/32] libxl_json: Enable yajl_allow_trailing_garbage

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Aug 02, 2018 at 12:01:23PM +0200, Roger Pau Monné wrote:
> On Fri, Jul 27, 2018 at 03:05:57PM +0100, Anthony PERARD wrote:
> > This allow to parse a string that is not NUL-terminated. With that
>        ^ allows
> > options disabled, YAJL v2 would look ahead on completion to find out if
>   ^ option
> > there is more to parse.
> > 
> > YAJL v1 doesn't have this behavior.
> > 
> > Any function function that allocate a yajl_handle via this function
>       ^ duplicated           ^ allocates
> > either parse a NUL-terminated string, or do provide proper length. So
> > change the default and allow garbage (like a different JSON document)
> > after the end of the data to parse.
> > 
> > This is importand for the QMP client, as there could be more than one
>           ^ important
> > message to parse, and YAJL would consider the next message to be
> > garbage and throw an error.
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 

With commit message fixed:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel