Re: [Xen-devel] [PATCH 06/34] x86: fix two unused variable errors when !CONFIG_HVM

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Aug 17, 2018 at 04:12:24PM +0100, Wei Liu wrote:
> The one in context_switch is fixed by annotating with __maybe_unused
> because I want to keep prevd around.
> 
> The other is fixed by eliminating v.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

> ---
>  xen/arch/x86/domain.c           | 3 ++-
>  xen/arch/x86/mm/shadow/common.c | 3 +--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
> index 5bb900e..574bdf0 100644
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -1671,7 +1671,8 @@ static void __context_switch(void)
>  void context_switch(struct vcpu *prev, struct vcpu *next)
>  {
>      unsigned int cpu = smp_processor_id();
> -    const struct domain *prevd = prev->domain, *nextd = next->domain;
> +    const struct domain * __maybe_unused prevd = prev->domain,
> +        *nextd = next->domain;

Could you align *nextd to prevd?

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel