Re: [Xen-devel] [PATCH 1/2] dmar: iommu mem leak fix

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.08.18 at 05:32, <zhenzhong.duan@xxxxxxxxxx> wrote:
> Release memory allocated for drhd iommu in error path.
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

But this needs a maintainer ack, and you didn't Cc him (now done).

Jan

> --- a/xen/drivers/passthrough/vtd/dmar.c
> +++ b/xen/drivers/passthrough/vtd/dmar.c
> @@ -100,6 +100,7 @@ static void __init disable_all_dmar_units(void)
>      {
>          list_del(&drhd->list);
>          scope_devices_free(&drhd->scope);
> +        iommu_free(drhd->iommu);
>          xfree(drhd);
>      }
>      list_for_each_entry_safe ( rmrr, _rmrr, &acpi_rmrr_units, list )
> -- 
> 1.7.3





_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel