Re: [Xen-devel] [PATCH v2] x86/hvm: remove default ioreq server

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.08.18 at 16:02, <paul.durrant@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -4093,12 +4093,15 @@ static int hvm_allow_set_param(struct domain *d,
>      case HVM_PARAM_CONSOLE_EVTCHN:
>      case HVM_PARAM_X87_FIP_WIDTH:
>          break;
> +    /* The following parameters are deprecated. */
> +    case HVM_PARAM_BUFIOREQ_EVTCHN:
> +        rc = -EPERM;
> +        break;
>      /*
>       * The following parameters must not be set by the guest
>       * since the domain may need to be paused.
>       */
>      case HVM_PARAM_IDENT_PT:
> -    case HVM_PARAM_DM_DOMAIN:
>      case HVM_PARAM_ACPI_S_STATE:
>      /* The remaining parameters should not be set by the guest. */
>      default:

So why again don't you add DM_DOMAIN alongside BUFIOREQ_EVTCHN
above (and remove it from hvm_set_param()), and then also to
hvm_allow_get_param()'s new deprecated group, plus respective
treatment in public/hvm/params.h? I can't find any use of this
except in the get/set functions here, and your qemu-trad patch
removes the sole use ("set" request) there.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel