Re: [Xen-devel] [PATCH v4 11/32] libxl_dm: Add libxl__qemu_qmp_path()

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Jul 27, 2018 at 03:05:53PM +0100, Anthony PERARD wrote:
> ... which generate the path to a QMP socket that libxl uses.
            ^ generates
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

> ---
> 
> Notes:
>     New in v4.
> 
>  tools/libxl/libxl_dm.c       | 9 +++++++--
>  tools/libxl/libxl_internal.h | 1 +
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index fdd7fa3ba4..5c28a0ced4 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -910,6 +910,11 @@ static char *qemu_disk_ide_drive_string(libxl__gc *gc, 
> const char *target_path,
>      return drive;
>  }
>  
> +const char *libxl__qemu_qmp_path(libxl__gc *gc, int domid)
> +{
> +    return GCSPRINTF("%s/qmp-libxl-%d", libxl__run_dir_path(), domid);
> +}

You could place this as a static inline function in libxl_internal.h
directly IMO.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel