Re: [Xen-devel] [PATCH v14 10/11] x86/hvm: Remove redundant save functions

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.07.18 at 15:32, <aisaila@xxxxxxxxxxxxxxx> wrote:
> On Ma, 2018-07-31 at 07:24 -0600, Jan Beulich wrote:
>> > > > On 25.07.18 at 14:14, <aisaila@xxxxxxxxxxxxxxx> wrote:
>> > --- a/xen/arch/x86/hvm/hpet.c
>> > +++ b/xen/arch/x86/hvm/hpet.c
>> > @@ -516,8 +516,9 @@ static const struct hvm_mmio_ops hpet_mmio_ops
>> > = {
>> >  };
>> >  
>> >  
>> > -static int hpet_save(struct domain *d, hvm_domain_context_t *h)
>> > +static int hpet_save(struct vcpu *vcpu, hvm_domain_context_t *h)
>> Consistently v please.
>> 
> Here the hpet_save() works with a local defined struct vcpu* v so I
> have struct vcpu *vcpu in order to change as little code as possible.
> If the v needs to be constant then I will change it in the next
> version. 

Yes please, but there's not a whole lot to change: Simply drop the
local variable declaration of v and make its initializer a normal
statement (as the function doesn't further care about the passed
in v).

Jan




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel