Re: [Xen-devel] [PATCH v14 08/11] x86/hvm: Add handler for save_one funcs

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.07.18 at 15:45, <aisaila@xxxxxxxxxxxxxxx> wrote:
> On Ma, 2018-07-31 at 07:32 -0600, Jan Beulich wrote:
>> > > > On 31.07.18 at 14:55, <aisaila@xxxxxxxxxxxxxxx> wrote:
>> > On Ma, 2018-07-31 at 06:34 -0600, Jan Beulich wrote:
>> > > > > > On 25.07.18 at 14:14, <aisaila@xxxxxxxxxxxxxxx> wrote:
>> > > > @@ -114,12 +117,13 @@ void hvm_register_savevm(uint16_t
>> > > > typecode,
>> > > >  
>> > > >  /* Syntactic sugar around that function: specify the max
>> > > > number of
>> > > >   * saves, and this calculates the size of buffer needed */
>> > > > -#define HVM_REGISTER_SAVE_RESTORE(_x, _save, _load, _num,
>> > > > _k)             \
>> > > > +#define HVM_REGISTER_SAVE_RESTORE(_x, _save, _save_one, _load,
>> > > > _num, _k)  \
>> > > >  static int __init
>> > > > __hvm_register_##_x##_save_and_restore(void)            \
>> > > >  {                                                             
>> > > >     
>> > > >         \
>> > > >      hvm_register_savevm(HVM_SAVE_CODE(_x),                    
>> > > >     
>> > > >         \
>> > > >                          #_x,                                  
>> > > >     
>> > > >         \
>> > > >                          &_save,                               
>> > > >     
>> > > >         \
>> > > > +                        _save_one,                            
>> > > >     
>> > > >         \
>> > > While I generally appreciate the omission of the &, I'd
>> > > prefer if you added it for consistency with the neighboring
>> > > lines.
>> > This was done so we can add NULL in the places that do not have
>> > save_one functions.
>> ??? (I cannot connect your response to my remark.)
>> 
> If there is &_save_one then it will not compile if there is any call
> with a NULL.
> 
> hpet.c: In function ‘__hvm_register_HPET_save_and_restore’:
> /home/aisaila/work/xen/xen/include/asm/hvm/save.h:126:25: error: lvalue
> required as unary ‘&’ operand
>                          &_save_one,                                   
>     \
>                          ^
> hpet.c:643:1: note: in expansion of macro ‘HVM_REGISTER_SAVE_RESTORE’
>  HVM_REGISTER_SAVE_RESTORE(HPET, hpet_save, NULL, hpet_load, 1,
> HVMSR_PER_DOM);

Oh, I'm sorry, that is quite obvious indeed.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel