[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v8 02/11] arm: make it possible to disable HAS_GICV3



Hi Jan,

On 31/07/18 09:04, Jan Beulich wrote:
On 30.07.18 at 19:48, <sstabellini@xxxxxxxxxx> wrote:
Today it is a silent option. This patch adds a one line description and
makes it optional.

Signed-off-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Acked-by: Julien Grall <julien.grall@xxxxxxx>
CC: George.Dunlap@xxxxxxxxxxxxx
CC: Ian.Jackson@xxxxxxxxxxxxx
CC: jbeulich@xxxxxxxx
CC: andrew.cooper3@xxxxxxxxxx

I continue to not understand why I'm being Cc-ed here. Now since I
am, ...

--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -12,7 +12,6 @@ config ARM_32
  config ARM_64
        def_bool y
        depends on 64BIT
-       select HAS_GICV3
config ARM
        def_bool y
@@ -42,6 +41,13 @@ config ACPI
config HAS_GICV3
        bool
+       prompt "GICv3 driver"

... why is this not simply

config HAS_GICV3
        bool "GICv3 driver"

?

I can fix that on commit.

Cheers,


Jan



--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.