Re: [Xen-devel] [PATCH v6] automation: introduce a script for build test

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Jul 25, 2018 at 02:40:13PM +0100, George Dunlap wrote:
> On 07/25/2018 02:29 PM, Wei Liu wrote:
> > On Wed, Jul 25, 2018 at 11:27:16AM +0100, George Dunlap wrote:
> >> On Wed, Jul 25, 2018 at 10:24 AM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> >>> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >>> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> >>> ---
> >>> This is a script I wrote previously for build test.
> >>>
> >>> Given it basically runs a set of commands on every commit, maybe it should
> >>> be named for-each-commit.sh ?
> >>
> >> Except that you also build just the whole series if the base and tip
> >> aren't specified.
> >>
> > 
> > What do you mean by this? Base and tip are required.
> 
> Oh, so it does.  Sorry, for some reason when I skimmed it the first time
> I thought I saw that it had two different modes.
> 
> >> Since it's about building a series (either all at once or one commit
> >> at a time), what about built-series?  Or series-build-test?
> >>
> > 
> > Not sure. My point was it could do more things than just building. You
> > can supply your own script or commands to do stuff with each commit.
> 
> Yes, in that case, something like for-each-commit would be sensible.
> Although I might consider not including the 'default build' command in
> the script in that case, on the grounds that it would violate the
> principle of least surprise for a script named "for-each-commit" to
> start building things on its own.

Thinking about it the main purpose of this script is help build test. It
can be (ab)used to some other things is secondary. I think I will keep
build-test.sh for now.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel