Re: [Xen-devel] [PATCH] firmware/shim : filter output files during Xen tree setup

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.07.18 at 02:21, <christopher.w.clark@xxxxxxxxx> wrote:
> On Tue, Jul 24, 2018 at 2:43 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> 
>> >>> On 20.07.18 at 23:15, <christopher.w.clark@xxxxxxxxx> wrote:
>> > Exclude named output files from the Xen tree setup.
>> >
>> > The linkfarm.stamp content will differ between top level "make"
>> > and "make install" invocations, due to the introduction of these
>> > output files that are produced during the "make" build.
>> >
>> > Filter these out to prevent an unnecessary rebuild of the shim during
>> > "make install".
>> >
>> > Signed-off-by: Christopher Clark <christopher.clark6@xxxxxxxxxxxxxx>
>> > ---
>> >  tools/firmware/xen-dir/Makefile | 6 +++++-
>> >  1 file changed, 5 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/tools/firmware/xen-dir/Makefile
>> > b/tools/firmware/xen-dir/Makefile
>> > index 84648c3..e490dca 100644
>> > --- a/tools/firmware/xen-dir/Makefile
>> > +++ b/tools/firmware/xen-dir/Makefile
>> > @@ -11,6 +11,9 @@ D=xen-root
>> >  LINK_DIRS=config xen
>> >  LINK_FILES=Config.mk
>> >
>> > +# Files to exclude from the link farm
>> > +EXCLUDE_FILES=xen xen.gz xen-syms xen-syms.map efi.lds xen.lds mkelf32
>> mkreloc
>>
>> What about xen.efi and all of its auxiliary files?
> 
> 
> Fair point - this list was from a non-EFI build, and EFI does add two more
> files to it: xen.efi and xen.efi.map

So what about the auxiliary ones created there, like ..xen-syms.* or
..xen.efi.*

>> What about other generated files?
>>
> 
> I don't see any others being added to the stamp file -- with the possible
> exception of the "disabled" file in xen/arch/x86/efi which can capture
> build errors. I don't think that file will be present in production builds.
> 
> Did you have any others in mind? I'll post an updated patch with the
> EFI-updated list in the meantime.

Besides the above ones, I'd suspect generated headers to show up
there, possibly only after having run a second (incremental) build in
that tree. I notice that the *.[isoa] exclusion already takes care of
avoiding e.g. asm-offsets.s.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel