[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [Minios-devel] automation: Creating a patchwork instance to improve pre-commit build testing
- To: Lars Kurth <lars.kurth@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, Lars Kurth <lars.kurth.xen@xxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 24 Jul 2018 14:10:57 +0100
- Autocrypt: addr=andrew.cooper3@xxxxxxxxxx; prefer-encrypt=mutual; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA==
- Cc: Iurii Artemenko <Iurii_Artemenko@xxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Minios-devel <minios-devel@xxxxxxxxxxxxxxxxxxxx>, Committers <committers@xxxxxxxxxxxxxx>, 'Jan Beulich' <JBeulich@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Matt Spencer <Matt.Spencer@xxxxxxx>
- Delivery-date: Tue, 24 Jul 2018 13:13:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Openpgp: preference=signencrypt
On 24/07/18 10:57, Lars Kurth wrote:
>
> On 24/07/2018, 10:46, "Wei Liu" <wei.liu2@xxxxxxxxxx> wrote:
>
> On Tue, Jul 24, 2018 at 10:38:24AM +0100, Lars Kurth wrote:
> >
> >
> > > On 24 Jul 2018, at 10:24, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> > >
> > > On Tue, Jul 24, 2018 at 03:06:08AM -0600, Jan Beulich wrote:
> > >>>>> On 23.07.18 at 18:40, <lars.kurth@xxxxxxxxxx> wrote:
> > >>> # How does this impact me?
> > >>> The contribution workflow is *not* impacted by this change, but
> once up and
> > >>> running the following will happen once you post a patch or patch
> series to
> > >>> xen-devel:
> > >>> * Patchwork will take patch series from the mailing list and
> applies it
> > >>> * CI/DC testing is triggered
> > >>> * A test report will be sent as a mail to the patch or the series
> (aka the 00 patch of the series)
> > >>>
> > >>> This does mean though that series which do not build or show other
> issues,
> > >>> will likely not be reviewed until the tests pass. This would lessen
> the
> > >>> burden on reviewers, as they will know whether the code submitted
> builds on a
> > >>> wide array of environments.
> > >>
> > >> So how are dependencies between series intended to be dealt with? It
> > >> is not uncommon for someone to say "applies only on top of xyz". The
> > >> implication of "will likely not be reviewed until the tests pass"
> seems
> > >> unsuitable to me in such a case.
> > >>
> > >
> > > We have been asking everyone to rebase to staging before posting a new
> > > version for a long time. It is natural for the bot to assume that
> > > everything should apply on top of staging. That would provide most
> value
> > > to the community.
> > >
> > > For special cases like you just mention, we should aim to provide
> > > mechanisms to manually appoint a branch to be tested.
> >
> > Wei, Doug: I have another question, which is mainly for my own
> understanding.
> >
> > Right now we allow posting of patches to Linux, Qemu, xen.git,
> > OSSTEST, ... to xen-devel. The planned CI infrastructure only applies
> > to xen.git. Have you thought about how to handle such cases?
>
> No. I haven't. We may be able to use some heuristics here.
>
> Or an alternative would be to say: if you want to use the test bot then CC
> xengit-testbot@xxxxxxxxxxxxxx (or something like it) when you submit the
> series. That would also get around Jan's issue with dependent series: you
> would simply not add the CC, when you know it won't build without a
> dependency.
If you require contributors to opt into automation, people will won't
know or forget, and reviewers will first have to ask people to submit
full series again CC'ing the correct bot.
-100 to any idea which requires an opt-in. It should be active by default.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
