[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V3] xen/altp2m: set access_required properly for all altp2ms



Hi,

On 23/07/18 12:40, George Dunlap wrote:
On 07/16/2018 09:53 AM, Jan Beulich wrote:
On 16.07.18 at 10:35, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
On 06/28/2018 07:19 PM, Tamas K Lengyel wrote:
On Thu, Jun 28, 2018 at 1:54 AM Razvan Cojocaru
<rcojocaru@xxxxxxxxxxxxxxx> wrote:

For the hostp2m, access_required starts off as 0, then it can be
set with xc_domain_set_access_required(). However, all the altp2ms
set it to 1 on init, and ignore both the hostp2m and the hypercall.
This patch sets access_required to the value from the hostp2m
on altp2m init, and propagates the values received via hypercall
to all the active altp2ms, when applicable.

Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>

LGTM

Acked-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>

Thanks Tamas!

Does the patch need additional action before it can go in (sorry for the
noise if it only hasn't gone in because it at the back of the queue).

Once again - George's ack is missing. Please remember that generally
it's the submitter to chase ack-s, not reviewers or committers.

Do we need Julien's ack too?

Ravzan and Tamas are maintaining arm/mem_access.c. So Tamas's ack should be enough here. Just in case:

Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.