Re: [Xen-devel] [PATCH] shim: Fix generation of compat/callback.i: allow redef of OBJECT vars

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 19 Jul 2018, Jan Beulich wrote:
> >>> Stefano Stabellini <sstabellini@xxxxxxxxxx> 07/19/18 7:00 PM >>>
> >On Thu, 19 Jul 2018, Jan Beulich wrote:
> >> > Signed-off-by: Christopher Clark <christopher.clark6@xxxxxxxxxxxxxx>
> >> > ---
> >> > Please use my gmail address for any correspondence to me.
> >> 
> >> I think it is generally considered bad practice to have From: and S-o-b
> >> differ.
> >
> >Why? That is perfectly fine. Signed-off-by is about copyright of the
> >code while From: is about authorship. 
> 
> Well, in this particular case Christopher had even asked that communication
> to go to the mail address he sent from. How is anyone going to know that if
> judging just from the eventual commit in git?

Yeah, that bit of information is lost in the commit message,
unfortunately. At that point, the patch is already committed, so it is
usually not a big deal.


> Besides that - how does anyone know whether the two are actually addresses
> of the same person?

I don't think they have to be the same person. What matters is the
Signed-off-by line, the author is only to give credits to whom did the
work. It could be a pseudonym. While the Signed-off-by has to be a real
person.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel