Re: [Xen-devel] [PATCH] tools: fix dependency for ipxe and rombios

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Jul 18, 2018 at 11:09:39AM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH] tools: fix dependency for ipxe and rombios"):
> > On Tue, Jul 17, 2018 at 11:47:41AM +0100, Wei Liu wrote:
> > > On Tue, Jul 17, 2018 at 11:18:59AM +0100, Ian Jackson wrote:
> > > > So I'm sorry to say that I think the answer is to revert 01d631028a02
> > > > and to replace it with a patch which introduces
> > > >    --with-ipxe=/PATH
> > > >    --with-ipxe          like --enable-ipxe, but also sets path to ""
> > > >    --without-ipxe       same as --disable-ipxe
> > 
> > FAOD do you suggest we get rid of --with-system-ipxe? That seems to
> > deviate from other options.
> 
> Yes.
> 
> > If we don't ditch it, we will have:
> > 
> >   --with-ipxe         enable building and use in-tree ipxe.
> >   --without-ipxe      disable in-tree ipxe, no ipxe (in-tree or system
> >                       provided) will be used.
> >   --with-system-ipxe=PATH  disable building in-tree ipxe, use ipxe specified
> >                            by user.
> > 
> > But honestly I don't see the advantage of this other than keeping
> > options consistent.
> 
> Well, normally --with-system-foo=PATH would mean both "please use PATH
> when building" and "please bake PATH into your program".

And that's exactly what we want here, right? If --with-system-ipxe=/PATH is
specified, the PATH is baked into libxl.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel