Re: [Xen-devel] [PATCH v2 2/2] x86/altp2m: Add a subop for obtaining the memaccess of a page

[Adrian Pop <apop@xxxxxxxxxxxxxxx>]

On Mon, Jul 09, 2018 at 02:35:30AM -0600, Jan Beulich wrote:
> >>> On 05.07.18 at 12:44, <apop@xxxxxxxxxxxxxxx> wrote:
> > Both altp2m get/set memaccess functions use the struct
> > xen_hvm_altp2m_mem_access which has now dropped the `set' part and has
> > been renamed from xen_hvm_altp2m_set_mem_access.
> > 
> > Signed-off-by: Adrian Pop <apop@xxxxxxxxxxxxxxx>
> 
> Looking through this patch - what's the point of patch 1? There's no
> further user being introduced here.

It's not entirely necessary.  It just cleans up _p2m_get_mem_access()
slightly, which would be the only user of the new function.  I could
drop patch 1 and if it's deemed desirable I could send it separately.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel