Re: [Xen-devel] [PATCH v2 20/21] xen: support console_switching between Dom0 and DomUs on ARM

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.07.18 at 18:43, <sstabellini@xxxxxxxxxx> wrote:
> On Tue, 17 Jul 2018, Jan Beulich wrote:
>> >>> On 16.07.18 at 23:55, <sstabellini@xxxxxxxxxx> wrote:
>> > On Mon, 16 Jul 2018, Jan Beulich wrote:
>> >> >>> On 07.07.18 at 01:12, <sstabellini@xxxxxxxxxx> wrote:
>> >> > @@ -389,29 +392,49 @@ static void dump_console_ring_key(unsigned char 
>> >> > key)
>> >> >      free_xenheap_pages(buf, order);
>> >> >  }
>> >> >  
>> >> > -/* CTRL-<switch_char> switches input direction between Xen and DOM0. */
>> >> > +/*
>> >> > + * CTRL-<switch_char> switches input direction between Xen, Dom0 and
>> >> > + * DomUs.
>> >> > + */
>> >> >  #define switch_code (opt_conswitch[0]-'a'+1)
>> >> > -static int __read_mostly xen_rx = 1; /* FALSE => input passed to 
>> >> > domain 0. 
> */
>> >> > +static int __read_mostly xen_rx = 1; /* 1 => input passed to domain 0. 
>> >> > */
>> >> 
>> >> I guess this variable wants renaming now.
>> > 
>> > Yeah. What about `console_rx'? 
>> 
>> That's reasonable. Another option would be to use rx_domid, and store
>> actual domain IDs there (DOMID_XEN for Xen). That'll make the switching
>> logic slightly larger, but perhaps provide a better understandable end
>> result.
> 
> What about keeping the logic simple and adding a better comment to
> explain how console_rx works:
> 
> /*
>  * console_rx=0 => input to xen
>  * console_rx=1 => input to dom0
>  * console_rx=N => input dom(N-1)
>  */

Well, as said - my suggestion is "another option", not something I'd insist
on. Unless others prefer on of them, I'd say it's up to you.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel