Re: [Xen-devel] [PATCH v2 4/6] osstest: limit FreeBSD jobs to hardware booting in BIOS mode

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v2 4/6] osstest: limit FreeBSD jobs to hardware 
booting in BIOS mode"):
> There's no support yet in osstest to install FreeBSD from UEFI, so for
> the time being limit the FreeBSD jobs to boxes booting with legacy
> BIOS.

I did a diff of the output of
  OSSTEST_CONFIG=standalone-config-example eatmydata 
./standalone-generate-dump-flight-runvars
between current production, and after applying this patch, and I saw
these changes:

+freebsd-master             build-amd64-freebsd       all_hostflags       
PropEq:Firmware:bios:bios           
+freebsd-master             build-amd64-freebsd-again all_hostflags       
PropEq:Firmware:bios:bios           

These are expected, I think.

-freebsd-master             build-amd64-freebsd       freebsd_distpath    
/amd64                              
-freebsd-master             build-amd64-freebsd       freebsd_version           
                              

I don't think I understand these changes.

+examine                    examine-SOMEHOST  all_hostflags           
PropEq:Firmware:bios:bios                                     

This is wrong.  The examine job needs to run on all hosts and
shouldn't have that hostflag applied.

I also notice that you did a runvar difference only of a xen-unstable
flight.  Looking at the differences between production and the tip of
your series, I think you are perhaps adding the freebsd xen build job
to rather too many of these flights.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel