Re: [Xen-devel] [PATCH 2/2] x86/HPET: adjustments to constants and their use

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.07.18 at 11:12, <roger.pau@xxxxxxxxxx> wrote:
> On Tue, Jul 17, 2018 at 02:35:40AM -0600, Jan Beulich wrote:
>> --- a/xen/arch/x86/hvm/hpet.c
>> +++ b/xen/arch/x86/hvm/hpet.c
>> @@ -41,14 +41,8 @@
>>  #define guest_time_hpet(hpet) \
>>      (hvm_get_guest_time(vhpet_vcpu(hpet)) / STIME_PER_HPET_TICK)
>>  
>> -#define HPET_TN_INT_ROUTE_CAP_SHIFT 32
>> -
>>  /* can be routed to IOAPIC.redirect_table[23..20] */
>> -#define HPET_TN_INT_ROUTE_CAP      (0x00f00000ULL \
>> -                    << HPET_TN_INT_ROUTE_CAP_SHIFT)
>> -
>> -#define HPET_TN_INT_ROUTE_CAP_MASK (0xffffffffULL \
>> -                    << HPET_TN_INT_ROUTE_CAP_SHIFT)
>> +#define HPET_TN_INT_ROUTE_CAP_VAL MASK_INSR(0x00f00000, 
> HPET_TN_INT_ROUTE_CAP)
> 
> I might be clearer to define this as:
> (1 << 20 | 1 << 21 | 1 << 22 | 1 << 23)
> but it's also quite cumbersome.

Indeed (the "cumbersome").

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel