Re: [Xen-devel] [PATCH] tboot: Avoid recursive fault in early boot panic with tboot

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Mon, Jul 16, 2018 at 8:22 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 16.07.18 at 13:59, <jandryuk@xxxxxxxxx> wrote:
>> --- a/xen/arch/x86/tboot.c
>> +++ b/xen/arch/x86/tboot.c
>> @@ -391,7 +391,12 @@ void tboot_shutdown(uint32_t shutdown_type)
>>          tboot_gen_xenheap_integrity(g_tboot_shared->s3_key, &xenheap_mac);
>>      }
>>
>> -    write_ptbase(idle_vcpu[0]);
>> +    /* During early boot, we can be called by panic before idle_vcpu[0] is
>> +     * setup, but in that case we don't need to change page tables. */
>> +    if ( idle_vcpu[0] != INVALID_VCPU )
>> +    {
>> +        write_ptbase(idle_vcpu[0]);
>> +    }
>
> There are two style issues here: The comment wants to be properly
> formatted, and the braces want to be dropped.
>
> Also please honor patch submission rules - they get sent _to_ the
> list, with maintainers _cc_-ed.

Ok.  Sorry for all the errors and thanks for the pointers.

Regards,
Jason

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel