Re: [Xen-devel] [PATCH v2 11/13] x86: Introduce struct cpu_policy to refer to a group of individual policies

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.07.18 at 22:03, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/sysctl.c
> +++ b/xen/arch/x86/sysctl.c
> @@ -31,6 +31,33 @@
>  #include <asm/psr.h>
>  #include <asm/cpuid.h>
>  
> +const struct cpu_policy system_policies[] = {

By the end of the series the array remains unused outside this
source file. I'd appreciate if it was made extern only when actually
needed, not the least because ...

> +    [ XEN_SYSCTL_cpu_policy_raw ] = {
> +        &raw_cpuid_policy,
> +        &raw_msr_policy,
> +    },
> +    [ XEN_SYSCTL_cpu_policy_host ] = {
> +        &host_cpuid_policy,
> +        &host_msr_policy,
> +    },
> +    [ XEN_SYSCTL_cpu_policy_pv_max ] = {
> +        &pv_max_cpuid_policy,
> +        &pv_max_msr_policy,
> +    },
> +    [ XEN_SYSCTL_cpu_policy_hvm_max ] = {
> +        &hvm_max_cpuid_policy,
> +        &hvm_max_msr_policy,
> +    },
> +    [ XEN_SYSCTL_cpu_policy_pv_default ] = {
> +        &pv_max_cpuid_policy,
> +        &pv_max_msr_policy,
> +    },
> +    [ XEN_SYSCTL_cpu_policy_hvm_default ] = {
> +        &hvm_max_cpuid_policy,
> +        &hvm_max_msr_policy,
> +    },
> +};

... this does not make obvious (without consulting sysctl.h) that
there are now holes (and hence hidden NULL pointers); this is
perhaps already undesirable with the user of this array that the
next patch adds.

With "static" added and the "extern" dropped from the header
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel