Re: [Xen-devel] [PATCH v2 01/13] x86/msr: Drop stale comment for vcpu_msrs.spec_ctrl

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Jul 13, 2018 at 09:03:02PM +0100, Andrew Cooper wrote:
> More than the bottom two bits are now defined, and the MSR policy work has
> shown that using non-architectural representations turns out to be problematic
> for more than just asm code.  As the architectural representation is the
> expected default, we don't need to justify why we are using it.

If that's indeed the architectural representation shouldn't you use a
uint64_t instead?

> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel