Re: [Xen-devel] [PATCH v2 07/13] libx86: Introduce a helper to serialise cpuid_policy objects

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jul 13, 2018 at 09:03:08PM +0100, Andrew Cooper wrote:
> +#include <errno.h>
>  #include <inttypes.h>
>  #include <stdbool.h>
>  #include <stddef.h>
> @@ -23,6 +28,19 @@ static inline bool test_bit(unsigned int bit, const void 
> *vaddr)
>      return addr[bit / 8] & (1u << (bit % 8));
>  }
>  
> +/* memcpy(), but with copy_to_guest_offset()'s API. */
> +#define copy_to_buffer_offset(dst, index, src, nr)      \
> +({                                                      \
> +    const typeof(*(dst)) *src_ = (src);                 \

I think you mean typeof(*(src)) here?

Otherwise:

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel