Re: [Xen-devel] [PATCH] xen: oprofile/nmi_int.c: Drop unwanted sexual reference

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jul 12, 2018 at 03:41:55PM +0100, Ian Jackson wrote:
> This is not really very nice.
> 
> I don't understand the technical details here but `violence' is
> probably fair.  The word `violence' is often used metaphorically in a
> technical context so I think it's probably OK for use in this way.
> 
> IMO this patch should be backported to all maintained trees.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> ---
>  xen/arch/x86/oprofile/nmi_int.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/oprofile/nmi_int.c b/xen/arch/x86/oprofile/nmi_int.c
> index d8f5230..cc36827 100644
> --- a/xen/arch/x86/oprofile/nmi_int.c
> +++ b/xen/arch/x86/oprofile/nmi_int.c
> @@ -182,7 +182,7 @@ int nmi_reserve_counters(void)
>       if (!allocate_msrs())
>               return -ENOMEM;
>  
> -     /* We walk a thin line between law and rape here.
> +     /* We walk a thin line between law and violence here.

IMHO this line doesn't have much value in itself. The rest of this
comment block is pretty clear what it wants to convey.

Wei.

>        * We need to be careful to install our NMI handler
>        * without actually triggering any NMIs as this will
>        * break the core code horrifically.
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel