Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.07.18 at 17:35, <roger.pau@xxxxxxxxxx> wrote:
> On Tue, Jul 10, 2018 at 08:09:06AM -0600, Jan Beulich wrote:
>> >>> On 10.07.18 at 15:49, <roger.pau@xxxxxxxxxx> wrote:
>> > On Tue, Jul 10, 2018 at 05:47:19AM -0600, Jan Beulich wrote:
>> >> >>> On 10.07.18 at 13:00, <daniel.kiper@xxxxxxxxxx> wrote:
>> >> > On Mon, Jul 09, 2018 at 06:45:16PM +0200, Roger Pau Monné wrote:
>> >> >> Sorry for asking so many questions, but I would like to try to avoid
>> >> >> the DEFINED conditional in the linker script if possible.
>> >> > 
>> >> > If you wish to do that then put dummy efi symbol into 
>> >> > xen/arch/x86/efi/stub.c.
>> >> 
>> >> I think I've clearly objected to that before - I simply see no need for
>> >> wasting the space in an EFI-incapable binary.
>> > 
>> > But such waste is also added regardless of whether you define the
>> > symbol it in the linker script or in a C file?
>> 
>> How that? There's no space associated with the symbol when defined
>> this way. From the perspective of the binary, the space lives past the
>> end of the image, but since the symbol is never accessed (or else code
>> is broken somewhere) in the non-EFI case, this is okay.
> 
> Oh right, that's not inside of any section.
> 
> I've tried placing an efi symbol inside of the .discard section but
> that doesn't work.

In which way?

> I'm open to suggestions since I don't have any more
> ideas about how to fix this.

Another possible thing to try might be to make the extern declaration
of the symbol weak, and drop the offending line altogether.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel