Re: [Xen-devel] [PATCH 1/2] xen: Introduce an xmemdup() helper

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.07.18 at 14:08, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 09/07/18 13:02, Jan Beulich wrote:
>>>>> On 09.07.18 at 12:29, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> --- a/xen/arch/x86/cpuid.c
>>> +++ b/xen/arch/x86/cpuid.c
>>> @@ -703,16 +703,17 @@ void recalculate_cpuid_policy(struct domain *d)
>>>  
>>>  int init_domain_cpuid_policy(struct domain *d)
>>>  {
>>> -    d->arch.cpuid = xmalloc(struct cpuid_policy);
>>> +    struct cpuid_policy *p =
>>> +        xmemdup(is_pv_domain(d) ? & pv_max_cpuid_policy
>> Stray blank (same below in the MSR equivalent).
> 
> That was the visually line up the _max_cpuid_policy with hvm below.
> 
> Another option would be "?  &pv_" with a double space before the &.

Either way looks a little strange to me, but if you prefer to have things
aligned this way, then I'll leave it to you which of the two options you
pick (I have only a very slight preference to the alternative you've
no suggested).

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel