[Xen-devel] Ping: [PATCH] x86: correctly set nonlazy_xstate_used when loading full state

["Jan Beulich" <JBeulich@xxxxxxxx>]

Ping?

>>> On 26.06.18 at 09:47, <JBeulich@xxxxxxxx> wrote:
> In this case, just like xcr0_accum, nonlazy_xstate_used should always be
> set to the intended new value, rather than possibly leaving the flag set
> from a prior state load.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> --- a/xen/arch/x86/domctl.c
> +++ b/xen/arch/x86/domctl.c
> @@ -1187,8 +1187,7 @@ long arch_do_domctl(
>                  vcpu_pause(v);
>                  v->arch.xcr0 = _xcr0;
>                  v->arch.xcr0_accum = _xcr0_accum;
> -                if ( _xcr0_accum & XSTATE_NONLAZY )
> -                    v->arch.nonlazy_xstate_used = 1;
> +                v->arch.nonlazy_xstate_used = _xcr0_accum & XSTATE_NONLAZY;
>                  compress_xsave_states(v, _xsave_area,
>                                        evc->size - PV_XSAVE_HDR_SIZE);
>                  vcpu_unpause(v);
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -1324,8 +1324,7 @@ static int hvm_load_cpu_xsave_states(str
>  
>      v->arch.xcr0 = ctxt->xcr0;
>      v->arch.xcr0_accum = ctxt->xcr0_accum;
> -    if ( ctxt->xcr0_accum & XSTATE_NONLAZY )
> -        v->arch.nonlazy_xstate_used = 1;
> +    v->arch.nonlazy_xstate_used = ctxt->xcr0_accum & XSTATE_NONLAZY;
>      compress_xsave_states(v, &ctxt->save_area,
>                            size - offsetof(struct hvm_hw_cpu_xsave, 
> save_area));
>  




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel