Re: [Xen-devel] [PATCH 6/6] osstest: add FreeBSD Xen build job

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH 6/6] osstest: add FreeBSD Xen build job"):
...
> +create_freebsd_xen_build_job () {
> +  job_create_build build-$arch-xen$xsm_suffix-freebsd build-xen-freebsd    \
> +    arch=$arch                                                             \
> +    enable_xsm=$enable_xsm $livepatch_runvars                              \
> +    tree_qemuu=$TREE_QEMU_UPSTREAM                                         \
> +    tree_xen=$TREE_XEN                                                     \
> +    tree_seabios=$TREE_SEABIOS                                             \
> +    $RUNVARS $BUILD_RUNVARS $BUILD_XEN_RUNVARS $arch_runvars               \
> +    host_hostflags=arch-$arch,purpose-build                                \
> +    revision_xen=$REVISION_XEN                                             \
> +    revision_qemu=$REVISION_QEMU                                           \
> +    revision_qemuu=$REVISION_QEMU_UPSTREAM                                 \
> +    revision_seabios=$REVISION_SEABIOS                                     \
> +    all_host_os=freebsd $freebsd_runvars

Can we not have xen_build_job_runvars or something ?  This is still
very similar to what is in mfi-common's create_build_jobs.

The rest of this looks fine to me.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel