Re: [Xen-devel] [PATCH v10 01/11] x86/cpu: Introduce vmce_save_vcpu_ctxt_one() func

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.07.18 at 10:54, <aisaila@xxxxxxxxxxxxxxx> wrote:
> On Jo, 2018-07-05 at 08:41 +0000, Paul Durrant wrote:
>> > From: Alexandru Isaila [mailto:aisaila@xxxxxxxxxxxxxxx]
>> > Sent: 04 July 2018 14:32
>> > --- a/xen/arch/x86/cpu/mcheck/vmce.c
>> > +++ b/xen/arch/x86/cpu/mcheck/vmce.c
>> > @@ -349,6 +349,18 @@ int vmce_wrmsr(uint32_t msr, uint64_t val)
>> >      return ret;
>> >  }
>> > 
>> > +static int vmce_save_vcpu_ctxt_one(struct vcpu *v,
>> > hvm_domain_context_t *h)
>> > + {
>> > +    struct hvm_vmce_vcpu ctxt;
>> > +
>> Not my call, but I'd feel more comfortable with memsetting ctxt to
>> zero here...
> 
> If there will be a new version I will add the memset to 0

There will need to be a new version for this alone, but please allow some
more time for people to look at your series. At the rate you've been
sending versions, I haven't ever made it past the middle of your series.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel