Re: [Xen-devel] [PATCH 2/3] osstest: set the make command to use for xen-build

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Jul 03, 2018 at 04:12:06PM +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH 2/3] osstest: set the make command to use for 
> xen-build"):
> > The default make on FreeBSD is the BSD make, and Xen requires the GNU
> > make in order to build. Set the make command based on the OS for the
> > Xen build.
> ...
> >  our $dokconfig = 1;
> > +our $make = $ho->{OS} eq "freebsd" ? "gmake" : "make";
> 
> Wouldn't it be better to write
>    $ho->{OS} =~ m/bsd/
> or something ?

Yes, that's indeed better. Would you like me to send a new version
with this fixed?

> Subject to either changing that, or having an answer:
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel