Re: [Xen-devel] [PATCH 1/4] firmware/seabios: fix build on systems with non GNU toolchains

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Jul 02, 2018 at 10:32:15AM +0100, Wei Liu wrote:
> On Mon, Jul 02, 2018 at 10:28:23AM +0200, Roger Pau Monne wrote:
> [...]
> >  
> >  subtree-force-update:
> > @@ -128,3 +128,6 @@ endif
> >  subtree-force-update-all:
> >     $(MAKE) seabios-dir-force-update
> >     $(MAKE) ovmf-dir-force-update
> > +
> > +subdir-all-seabios-dir: seabios-dir
> > +   $(MAKE) -C $< CC=$(SEABIOSCC) LD=$(SEABIOSLD) PYTHON=$(PYTHON) all;
> 
> There is a pattern rule in Rules.mk, so I would very much avoid having
> it redefined.

I know, but I need to redefine it so I can pass the extra options. I
don't see any better way to do this TBH.

> On the other hand, you're not the first one to add such rules, so I
> won't object to this patch either.
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel