Re: [Xen-devel] [PATCH for-next 5/5] tools: provide --with-system-ipxe

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, May 15, 2018 at 07:22:43PM +0100, Wei Liu wrote:
> diff --git a/tools/configure.ac b/tools/configure.ac
> index 0826af8cbc..8e4b173d6f 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -241,6 +242,23 @@ AS_IF([test "x$ovmf" = "xy" -o -n "$ovmf_path" ], [
>                         [OVMF path])
>  ])
>  
> +AC_ARG_WITH([system-ipxe],
> +    AS_HELP_STRING([--with-system-ipxe@<:@=PATH@:>@],
> +       [Use system supplied IPXE PATH instead of building and installing
> +        our own version]),[
> +    # Disable compilation of IPXE.
> +    ipxe=n
> +    case $withval in
> +        no) ipxe_path= ;;
> +        *)  ipxe_path=$withval ;;
> +    esac
> +],[])
> +AS_IF([test "x$ipxe" = "xy" -o -n "$ipxe_path" ], [
> +    AC_DEFINE_UNQUOTED([IPXE_PATH],
> +                       ["${ipxe_path:-$XENFIRMWAREDIR/ipxe.bin}"],
> +                       [IPXE path])
> +])
> +

I think there are issues with the way we handle --with-system-X. If a
user run `configure --with-system-ipxe`, without a = or a PATH, then in
the hunk abrove, $withval will be "yes" and this will result with
IPXE_PATH=yes

I don't know if you want to look at that, since you're introducing a new
one.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel