Re: [Xen-devel] [OSSTEST PATCH v2 08/19] ts-guests-nbd-mirror: use target_{get, put}file_root to transfter cfg

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Mar 07, 2018 at 03:04:41PM +0000, Ian Jackson wrote:
> Wei Liu writes ("[OSSTEST PATCH v2 08/19] ts-guests-nbd-mirror: use 
> target_{get,put}file_root to transfter cfg"):
> > The original code used target_cmd_output_root which caused a trailing
> > new line to be deleted, which caused libvirt converter to fail.
> > 
> > It wasn't discovered until now because we appended too many "\n".
> > 
> > Use target_{get,put}file_root to do the job.
> 
> Maybe target_getfilecontents and stashfilecontents and
> target_putfilecontents would be easier and also better ?
> 
> It is usually better to use the existing facilities for inventing
> stash file names because they check for uniqueness.
> 

There is no target_getfilecontents, and the method I used is used
throughout osstest code.

> Or maybe you want to invent `target_getfile_stash' which uses
> open_unique_stashfile and target_getfile, and returns the filename.
> 

Let me see if I can invent something after fixing those more important
issues.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel