|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [libvirt test] 122494: regressions - FAIL
flight 122494 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/122494/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw 16 guest-start.2 fail REGR. vs. 122455 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-check fail like 122455 test-armhf-armhf-libvirt-xsm 14 saverestore-support-check fail like 122455 test-armhf-armhf-libvirt-raw 13 saverestore-support-check fail like 122455 test-amd64-amd64-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 14 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 12 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 13 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 12 migrate-support-check fail never pass test-armhf-armhf-libvirt 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 12 migrate-support-check fail never pass test-arm64-arm64-libvirt 13 migrate-support-check fail never pass test-arm64-arm64-libvirt 14 saverestore-support-check fail never pass version targeted for testing: libvirt ce5aebeacd10a1c15cb3ee46a59c8b5ff235589e baseline version: libvirt f94e5b215720c91c60219f1694783a603f0b619c Last test of basis 122455 2018-04-26 18:27:32 Z 3 days Testing same since 122494 2018-04-28 10:26:55 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Ehrhardt <christian.ehrhardt@xxxxxxxxxxxxx> Daniel P. Berrangé <berrange@xxxxxxxxxx> Laine Stump <laine@xxxxxxxxx> Peter Krempa <pkrempa@xxxxxxxxxx> jobs: build-amd64-xsm pass build-arm64-xsm pass build-armhf-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-armhf-armhf-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit ce5aebeacd10a1c15cb3ee46a59c8b5ff235589e Author: Laine Stump <laine@xxxxxxxxx> Date: Wed Apr 25 17:12:03 2018 -0400 nwfilter: increase pcap buffer size to be compatible with TPACKET_V3 When an nwfilter rule sets the parameter CTRL_IP_LEARNING to "dhcp", this turns on the "dhcpsnoop" thread, which uses libpcap to monitor traffic on the domain's tap device and extract the IP address from the DHCP response. If libpcap on the host is built with HAVE_TPACKET3 defined (to enable support for TPACKET_V3), the dhcpsnoop code's initialization of the libpcap socket would fail with the following error: virNWFilterSnoopDHCPOpen:1134 : internal error: pcap_setfilter: can't remove kernel filter: Bad file descriptor It turns out that this was because TPACKET_V3 requires a larger buffer size than libvirt was setting (we were setting it to 128k). Changing the buffer size to 256k eliminates the error, and the dhcpsnoop thread once again works properly. A fuller explanation of why TPACKET_V3 requires such a large buffer, for future git spelunkers: libpcap calls setsockopt(... SOL_PACKET, PACKET_RX_RING...) to setup a ring buffer for receiving packets; two of the attributes sent to this API are called tp_frame_size, and tp_frame_nr. If libpcap was built with HAVE_TPACKET3 defined, tp_trame_size is set to MAXIMUM_SNAPLEN (defined in libpcap sources as 262144) and tp_frame_nr is set to: [the buffer size we set, i.e. PCAP_BUFFERSIZE i.e. 262144] / tp_frame_size. So if PCAP_BUFFERSIZE < MAXIMUM_SNAPLEN, then tp_frame_nr (the number of frames in the ring buffer) is 0, which is nonsensical. This same value is later used as a multiplier to determine the size for a call to malloc() (which would also fail). (NB: if HAVE_TPACKET3 is *not* defined, then tp_frame_size is set to the snaplen set by the user (in our case 576) plus a small amount to account for ethernet headers, so 256k is far more than adequate) Since the TPACKET_V3 code in libpcap actually reads multiple packets into each frame, it's not a problem to have only a single frame (especially when we are monitoring such infrequent traffic), so it's okay to set this relatively small buffer size (in comparison to the default, which is 2MB), which is important since every guest using dhcp snooping in a nwfilter rule will hold 2 of these buffers for the entire life of the guest. Thanks to Christian Ehrhardt for discovering that buffer size was the problem (this was not at all obvious from the error that was logged!) Resolves: https://bugzilla.redhat.com/1547237 Fixes: https://bugs.launchpad.net/libvirt/+bug/1758037 Signed-off-by: Laine Stump <laine@xxxxxxxxx> Reviewed-by: Christian Ehrhardt <christian.ehrhardt@xxxxxxxxxxxxx> (V1) Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> Tested-by: Christian Ehrhardt <christian.ehrhardt@xxxxxxxxxxxxx> commit 6dd3679603f6ce1bae1e1b365731aacf427911a0 Author: Daniel P. Berrangé <berrange@xxxxxxxxxx> Date: Fri Apr 27 16:27:26 2018 +0100 Revert "news: Update the news file with the log filter wildcard improvement" This reverts commit 209d4d6f42a01829c68ef54b042a0c53ef0b22d3. The wildcard feature has been temporarily removed pending re-impl. Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> commit d32c0f9afe437afc93062722c927b259acf36e0f Author: Daniel P. Berrangé <berrange@xxxxxxxxxx> Date: Fri Apr 20 12:57:33 2018 +0100 Revert "util: virlog: Introduce wildcard to log filters" This reverts commit 8daa593b0741452a78daea76075254ae7d3c6ab6. There are two undesirable aspects to the impl - Only a bare wildcard is permitted - The wildcard match is not performed in the order listed Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> commit 96fc9fc5096b9d699c46bfd0baecab68c2138066 Author: Peter Krempa <pkrempa@xxxxxxxxxx> Date: Fri Apr 27 13:17:17 2018 +0200 qemu: migration: Set the 'set' boolean in qemuMigrationParamsSetString The code setting TLS parameters verifies that TLS is supported by looking at the dump of parameters which will be reset after migration, but sets the parameters in the list of new parameters. As qemuMigrationParamsSetString did not set the 'set' property, the TLS parameters would not be used. This is a regression after the series refactoring migration parameters and it resulted into TLS not being used even when requested. Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> commit d49c6e462367ab5747b394246f1a8a6fc38d5ced Author: Peter Krempa <pkrempa@xxxxxxxxxx> Date: Fri Apr 27 12:59:00 2018 +0200 qemu: migration: Move and unexport qemuMigrationParamsSetString The function is not used outside of the src/qemu/qemu_migration_params.c file so unexport it. Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |