[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report
Philippe Mathieu-Daudé <f4bug@xxxxxxxxx> writes: > On 04/19/2018 01:45 PM, Ian Jackson wrote: >> perror() is defined to fprintf(stderr,...). HACKING says >> fprintf(stderr,...) is wrong. So perror() is too. >> >> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> >> CC: Paolo Bonzini <pbonzini@xxxxxxxxxx> >> CC: Markus Armbruster <armbru@xxxxxxxxxx> >> CC: Daniel P. Berrange <berrange@xxxxxxxxxx> >> CC: Michael Tokarev <mjt@xxxxxxxxxx> >> CC: Alistair Francis <alistair.francis@xxxxxxxxxx> >> --- >> v7: New patch >> --- >> os-posix.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/os-posix.c b/os-posix.c >> index d4cf466..0108028 100644 >> --- a/os-posix.c >> +++ b/os-posix.c >> @@ -125,7 +125,7 @@ void os_set_proc_name(const char *s) >> /* Could rewrite argv[0] too, but that's a bit more complicated. >> This simple way is enough for `top'. */ >> if (prctl(PR_SET_NAME, name)) { >> - perror("unable to change process name"); >> + error_report("unable to change process name: %s", strerror(errno)); >> exit(1); >> } >> #else >> @@ -247,7 +247,7 @@ static void change_root(void) >> exit(1); >> } >> if (chdir("/")) { >> - perror("not able to chdir to /"); >> + error_report("not able to chdir to /: %s", strerror(errno)); >> exit(1); >> } >> } >> @@ -309,7 +309,7 @@ void os_setup_post(void) >> >> if (daemonize) { >> if (chdir("/")) { >> - perror("not able to chdir to /"); >> + error_report("not able to chdir to /: %s", strerror(errno)); >> exit(1); >> } >> TFR(fd = qemu_open("/dev/null", O_RDWR)); >> @@ -383,7 +383,7 @@ int os_mlock(void) >> >> ret = mlockall(MCL_CURRENT | MCL_FUTURE); >> if (ret < 0) { >> - perror("mlockall"); >> + error_report("mlockall: %s", strerror(errno)); >> } >> >> return ret; > > Thinking loudly, maybe we can refactor as error_report_errno(const char > *desc)... Maybe. If you want to try, make it a separate series not blocking this one. > Anyway: > Reviewed-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx> _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |