Re: [Xen-devel] [PATCH 1/3] xen: add generic fault injection facility

[<staskins@xxxxxxxxxx>]

On 04/20/18 12:59, Juergen Gross wrote:
> On 20/04/18 12:47, Stanislav Kinsburskii wrote:
> > diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> > index c1f98f3..483fc16 100644
> > --- a/arch/x86/xen/Kconfig
> > +++ b/arch/x86/xen/Kconfig
> > @@ -77,3 +77,10 @@ config XEN_PVH
> >         bool "Support for running as a PVH guest"
> >         depends on XEN && XEN_PVHVM && ACPI
> >         def_bool n
> > +
> > +config XEN_FAULT_INJECTION
> > +       bool "Enable Xen fault injection"
> > +       depends on FAULT_INJECTION_DEBUG_FS
> > +       default n
> > +       help
> > +         Enable Xen fault injection facility
> Why for x86 only? I'd rather add this under drivers/xen
Sure.

> > diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
> > index d83cb54..3158fe1 100644
> > --- a/arch/x86/xen/Makefile
> > +++ b/arch/x86/xen/Makefile
> > @@ -34,3 +34,4 @@ obj-$(CONFIG_XEN_DOM0)                += vga.o
> >   obj-$(CONFIG_SWIOTLB_XEN)     += pci-swiotlb-xen.o
> >   obj-$(CONFIG_XEN_EFI)         += efi.o
> >   obj-$(CONFIG_XEN_PVH)         += xen-pvh.o
> > +obj-$(CONFIG_XEN_FAULT_INJECTION)      += fault_inject.o
> > diff --git a/arch/x86/xen/fault_inject.c b/arch/x86/xen/fault_inject.c
> > new file mode 100644
> > index 0000000..ecf0f7c
> > --- /dev/null
> > +++ b/arch/x86/xen/fault_inject.c
> > @@ -0,0 +1,109 @@
> > +/*
> > + * Fauit injection interface for Xen virtual block devices
> > + *
> > + * Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License version 2
> > + * as published by the Free Software Foundation; or, when distributed
> > + * separately from the Linux kernel or incorporated into other
> > + * software packages, subject to the following license:
> Please use the appropriate SPDX header instead of the full GPL2
> boilerplate.
Ditto.

> Juergen
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel