Re: [Xen-devel] [PATCH 2/6] arm: make it possible to enable/disable UART drivers

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

Please CC "THE REST" maintainers here.

On 18/04/18 23:15, Stefano Stabellini wrote:
> All the UART drivers are silent options. Add one line descriptions so
> that can be de/selected via menuconfig.
>
> Signed-off-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> ---
>   xen/drivers/char/Kconfig | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
> index cc78ec3..b6fcefd 100644
> --- a/xen/drivers/char/Kconfig
> +++ b/xen/drivers/char/Kconfig
> @@ -1,11 +1,11 @@
>   config HAS_NS16550
> -       bool
> +       bool "NS16550 UART driver"
It looks like to me that x86 will require this unconditionally. So 
that's going to break randconfig.
>         default y
>         help
>           This selects the 16550-series UART support. For most systems, say Y.
>   
>   config HAS_CADENCE_UART
> -       bool
> +       bool "Xilinx Cadence UART driver"
>         default y
>         depends on ARM_64
>         help
> @@ -13,7 +13,7 @@ config HAS_CADENCE_UART
>           based board, say Y.
>   
>   config HAS_MVEBU
> -       bool am not entirely sure whether x86 require it by default.
> +       bool "Marvell MVEBU UART driver"
>         default y
>         depends on ARM_64
>         help
> @@ -21,7 +21,7 @@ config HAS_MVEBU
>           based board, say Y.
>   
>   config HAS_PL011
> -       bool
> +       bool "ARM PL011 UART driver"
>         default y
>         depends on ARM
>         help
> @@ -29,7 +29,7 @@ config HAS_PL011
>           an Integrator/PP2, Integrator/CP or Versatile platform, say Y.
>   
>   config HAS_EXYNOS4210
> -       bool
> +       bool "Samsung Exynos 4210 UART driver"
>         default y
>         depends on ARM_32
>         help
> @@ -37,7 +37,7 @@ config HAS_EXYNOS4210
>           Exynos based board, say Y.
>   
>   config HAS_OMAP
> -       bool
> +       bool "Texas Instruments OMAP UART driver"
>         default y
>         depends on ARM_32
>         help
> @@ -45,7 +45,7 @@ config HAS_OMAP
>           Instruments based CPU, say Y.
>   
>   config HAS_SCIF
> -       bool
> +       bool "SuperH SCI(F) UART driver"
>         default y
>         depends on ARM
>         help
> @@ -53,7 +53,7 @@ config HAS_SCIF
>           or Renesas R-Car Gen 2/3 based board say Y.
>   
>   config HAS_EHCI
> -       bool
> +       bool "EHCI UART driver"
Well, you are going to break at least Arm because this driver is not 
meant to be working there.
Furthermore, it looks like to me that x86 will require this unconditionally.

>         help
>           This selects the USB based EHCI debug port to be used as a UART. If
>           you have an x86 based system with USB, say Y.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel