Re: [Xen-devel] [PATCH 1/7] xen/arm: Added handling of the trapped access to OSLSR register

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 11 Apr 2018, Julien Grall wrote:
> Hi,
> 
> You seem to have used a wrong address for me.
> 
> Title: This patch is only adding the arm64 side. Please make it clear in it.

With that:

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> Cheers,
> 
> On 04/11/2018 02:19 PM, Mirela Simonovic wrote:
> > Linux/dom0 accesses OSLSR register when saving CPU context during the
> > suspend procedure. Xen traps access to this register, but has no handling
> > for it. Consequently, Xen injects undef exception to linux, causing it to
> > crash. This patch adds handling of the trapped access to OSLSR as ro/raz.
> > 
> > Signed-off-by: Mirela Simonovic <mirela.simonovic@xxxxxxxxxx>
> > ---
> >   xen/arch/arm/arm64/vsysreg.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/xen/arch/arm/arm64/vsysreg.c b/xen/arch/arm/arm64/vsysreg.c
> > index c57ac12503..8f80e1735e 100644
> > --- a/xen/arch/arm/arm64/vsysreg.c
> > +++ b/xen/arch/arm/arm64/vsysreg.c
> > @@ -57,13 +57,14 @@ void do_sysreg(struct cpu_user_regs *regs,
> >        * ARMv8 (DDI 0487A.d): D1-1509 Table D1-58
> >        *
> >        * Unhandled:
> > -     *    OSLSR_EL1
> >        *    DBGPRCR_EL1
> >        */
> >       case HSR_SYSREG_OSLAR_EL1:
> >           return handle_wo_wi(regs, regidx, hsr.sysreg.read, hsr, 1);
> >       case HSR_SYSREG_OSDLR_EL1:
> >           return handle_raz_wi(regs, regidx, hsr.sysreg.read, hsr, 1);
> > +    case HSR_SYSREG_OSLSR_EL1:
> > +        return handle_ro_raz(regs, regidx, hsr.sysreg.read, hsr, 1);
> > 
> >       /*
> >        * MDCR_EL2.TDA
> > 
> 
> --
> Julien Grall
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel