Re: [Xen-devel] [PATCH v2] x86/PVH/libxl: Check whether Linux guest can handle RSDP at 4G boundary

[Juergen Gross <jgross@xxxxxxxx>]

On 09/04/18 16:24, Boris Ostrovsky wrote:
> Commit 4a5733771e6f ("libxl: put RSDP for PVH guest near 4GB") breaks
> pre-4.17 Linux guests since they do not use start_info's rsdp_paddr
> pointer and instread scan BIOS memory for RSDP signature.
> 
> Introduce XENFEAT_rsdp_unrestricted feature flag that indicates whether
> the guest can handle RSDP at locations pointed to by rsdp_paddr.
> 
> Since only Linux PVH guests suffer from this problem (BSD has always
> relied on rsdp_paddr) we check this flag just for those guests. If the
> flag is not set we place RSDP in BIOS, as before.
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> ---
> v2:
> * Renamed flag to XENFEAT_linux_rsdp_unrestricted
> * Clarified comment in features.h
> 
> I did not include tags because of the changes but just in case ---
> here they are:
> 
> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>

So again:

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
Release-acked-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel