Re: [Xen-devel] [for-4.11][PATCH v7 16/16] xen: Convert page_to_mfn and mfn_to_page to use typesafe MFN

[Julien Grall <julien.grall@xxxxxxx>]

On 04/06/2018 09:19 AM, Julien Grall wrote:
> Hi,
> 
> On 04/03/2018 04:32 PM, Julien Grall wrote:
>>    xen/arch/x86/hvm/ioreq.c                |  4 ++--
> 
> There is a small clash with Paul's GFN typesafe for ioreq.
> Paul, do you want me to resend a patch for that?

FYI, this is what looks like the new patch for ioreq.c:


diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c
index 2275278305..3a201f5563 100644
--- a/xen/arch/x86/hvm/ioreq.c
+++ b/xen/arch/x86/hvm/ioreq.c
@@ -401,7 +401,7 @@ static void hvm_remove_ioreq_gfn(struct hvm_ioreq_server 
*s, bool buf)
         return;
 
     if ( guest_physmap_remove_page(d, iorp->gfn,
-                                   _mfn(page_to_mfn(iorp->page)), 0) )
+                                   page_to_mfn(iorp->page), 0) )
         domain_crash(d);
     clear_page(iorp->va);
 }
@@ -418,7 +418,7 @@ static int hvm_add_ioreq_gfn(struct hvm_ioreq_server *s, 
bool buf)
     clear_page(iorp->va);
 
     rc = guest_physmap_add_page(d, iorp->gfn,
-                                _mfn(page_to_mfn(iorp->page)), 0);
+                                page_to_mfn(iorp->page), 0);
     if ( rc == 0 )
         paging_mark_pfn_dirty(d, _pfn(gfn_x(iorp->gfn)));
 


> 
> Cheers,
> 

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel