Re: [Xen-devel] [PATCH v2] xl/libxl: add pvcalls support

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Mar 29, 2018 at 03:07:00PM -0700, Stefano Stabellini wrote:
> Add pvcalls support to libxl and xl. Create the appropriate pvcalls
> entries in xenstore.
> 
> Signed-off-by: Stefano Stabellini <stefano@xxxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Please also submit a doc patch.

> +#include "libxl_osdeps.h"
> +
> +#include "libxl_internal.h"
> +
> +static int libxl__device_pvcallsif_setdefault(libxl__gc *gc, uint32_t domid,
> +                                            libxl_device_pvcallsif 
> *pvcallsif,
> +                                            bool hotplug)

Indentation needs fixing, but this can be done upon committing.

>  
> +    if (!xlu_cfg_get_list(config, "pvcalls", &pvcallsifs_devs, 0, 0)) {
> +        d_config->num_pvcallsifs = 0;
> +        d_config->pvcallsifs = NULL;
> +        while ((buf = xlu_cfg_get_listitem (pvcallsifs_devs, 
> d_config->num_pvcallsifs)) != NULL) {
> +            libxl_device_pvcallsif *pvcallsif;
> +            char *backend = NULL;
> +            char *p, *p2, *buf2;
> +            pvcallsif = ARRAY_EXTEND_INIT(d_config->pvcallsifs,
> +                                   d_config->num_pvcallsifs,
> +                                   libxl_device_pvcallsif_init);

Same here.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel