Re: [Xen-devel] [RFC PATCH 08/12] libxl: Q35 support (new option device_model_machine)

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Mar 20, 2018 at 08:11:49AM +1000, Alexey G wrote:
> >>          if (b_info->u.hvm.mmio_hole_memkb) {
> >>              uint64_t max_ram_below_4g = (1ULL << 32) -
> >> diff --git a/tools/libxl/libxl_types.idl
> >> b/tools/libxl/libxl_types.idl index 35038120ca..f3ef3cbdde 100644
> >> --- a/tools/libxl/libxl_types.idl
> >> +++ b/tools/libxl/libxl_types.idl
> >> @@ -101,6 +101,12 @@ libxl_device_model_version =
> >> Enumeration("device_model_version", [ (2, "QEMU_XEN"),             #
> >> Upstream based qemu-xen device model ])
> >>  
> >> +libxl_device_model_machine = Enumeration("device_model_machine", [
> >> +    (0, "UNKNOWN"),  
> >
> >Shouldn't this be named DEFAULT?
> 
> "Unknown" here should be read as "unspecified", but I guess DEFAULT
> will be clearer anyway.
> 

I'm afraid the ship has already sailed. There are far too many UNKNOWNs
in libxl_types.idl so we might as well stick to it here.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel