Re: [Xen-devel] [PATCH v3] hvm/svm: Implement Debug events

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 21/03/18 14:47, Alexandru Isaila wrote:
> diff --git a/xen/include/asm-x86/hvm/hvm.h b/xen/include/asm-x86/hvm/hvm.h
> index 2376ed6..8d8c325 100644
> --- a/xen/include/asm-x86/hvm/hvm.h
> +++ b/xen/include/asm-x86/hvm/hvm.h
> @@ -209,6 +209,8 @@ struct hvm_function_table {
>                                  bool_t access_w, bool_t access_x);
>  
>      void (*enable_msr_interception)(struct domain *d, uint32_t msr);
> +    void (*enable_icebp_interception)(struct domain *d);
> +    void (*disable_icebp_interception)(struct domain *d);
>      bool_t (*is_singlestep_supported)(void);
>  
>      /* Alternate p2m */
> @@ -407,6 +409,20 @@ void hvm_migrate_pirqs(struct vcpu *v);
>  
>  void hvm_inject_event(const struct x86_event *event);
>  
> +static inline void hvm_inject_exception(
> +    unsigned int vector, unsigned int type,
> +    unsigned int insn_len,int error_code)

Space after comma.

> +{
> +    struct x86_event event = {
> +        .vector = vector,
> +        .type = type,
> +        .insn_len = insn_len,
> +        .error_code = error_code,
> +    };
> +
> +    hvm_inject_event(&event);
> +}
> +
>  static inline void hvm_inject_hw_exception(unsigned int vector, int errcode)
>  {
>      struct x86_event event = {
> @@ -581,6 +597,26 @@ static inline bool_t hvm_enable_msr_interception(struct 
> domain *d, uint32_t msr)
>      return 0;
>  }
>  
> +static inline bool_t hvm_enable_icebp_interception(struct domain *d)

bool.

Both can be fixed on commit, and everything else looks ok, so
Revewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

I've got a plan which will remove these enable/disable hooks, but we
need a bit more infrastructure from my CPUID series before they can go.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel