Re: [Xen-devel] [PATCH 2/3] x86/pv: Fold {compat_}unregister_guest_callback() into its non-compat counterpart

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.03.18 at 12:58, <andrew.cooper3@xxxxxxxxxx> wrote:
> These functions are almost identical.  They differ only in the error emitted
> for the use of CALLBACKTYPE_syscall (which is inconsequential to guests),

I'm not entirely convinced - so far there's been a match here between
map and unmap, i.e. with the change it may be advisable for
compat_register_guest_callback() to also return -EINVAL for
CALLBACKTYPE_syscall. However, I don't feel strongly about this, so
either way ...

> and
> the type of their argument.
> 
> Have the callers pass the unreg.type parameter directly, avoiding the need for
> differently typed parameters.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel