[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 5/5] hvmloader: Use iPXE ROM loaded from a standalone file
>>> On 19.03.18 at 15:24, <anoob.soman@xxxxxxxxxx> wrote: > On 16/03/18 11:26, Jan Beulich wrote: >>> >>> + /* Physical address of iPXE ROM, loaded by domain builder >>> + * when using ROMBIOS >>> + */ >>> + unsigned int *ipxe_rom_addresss; >> Comment style. And can the pointer be to const? > > I will fixup the comment style and but making ipxe_rom_address a pointer > to const will require codes changes in hvmloader/rombios.c, > hvmloader/optionroms.c to make all function that use ipxe_rom_address > const as well. Are you fine with changing these files/functions. In a separate patch, yes. If you don't want to create a separate patch, I'm also fine with your explanation of why it can't be const for now. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |