Re: [Xen-devel] [PATCH v9 09/11] vpci/msi: add MSI handlers

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.03.18 at 15:04, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -47,6 +47,10 @@ void vpci_remove_device(struct pci_dev *pdev)
>          xfree(r);
>      }
>      spin_unlock(&pdev->vpci->lock);
> +#ifdef __XEN__
> +    /* NB: fields below are not exposed to the user-space test harness. */
> +    xfree(pdev->vpci->msi);
> +#endif

Would it maybe be better to add such dummy field(s), to avoid the
#ifdef here? Anyway, with or without that
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel