Re: [Xen-devel] [PATCH 12/12] scripts/get_maintainer.pl: Print proper error message for missing $file

[Paolo Bonzini <pbonzini@xxxxxxxxxx>]

On 08/03/2018 20:03, Ian Jackson wrote:
> If you pass scripts/get_maintainer.pl the name of a FIFO or other
> exciting object (/dev/stdin, for example), it would falsely print
> "file not found".  Instead: stat the object rather than using -f so
> that we do not mind if the object is not a file; and print the errno
> value in the error message.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Thomas Huth <thuth@xxxxxxxxxx>
> CC: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
> v6: New patch in this version of the series
> ---
>  scripts/get_maintainer.pl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 07369aa..43fb5f5 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -381,8 +381,8 @@ foreach my $file (@ARGV) {
>       ##if $file is a directory and it lacks a trailing slash, add one
>       if ((-d $file)) {
>           $file =~ s@([^/])$@$1/@;
> -     } elsif (!(-f $file)) {
> -         die "$P: file '${file}' not found\n";
> +     } elsif (!(stat $file)) {
> +         die "$P: file '${file}' not found: $!\n";
>       }
>      }
>      if ($from_filename) {
> 

Queued, thanks.

Paolo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel