Re: [Xen-devel] [PATCH v6 1/9] x86/mm: add pv prefix to {alloc, free}_page_type

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.02.18 at 21:04, <wei.liu2@xxxxxxxxxx> wrote:
> The two functions are only used by PV code paths because:
> 
> 1. To allocate a PGT_l*_page_table type page, a DomU must explicitly
>    request such types via PV MMU hypercall.
> 2. PV Dom0 builder explicitly asks for PGT_l*_page_table type pages,
>    but it is obviously PV only.
> 3. p2m_alloc_ptp explicitly sets PGT_l1_page_table, but the allocation
>    and deallocation of such pages don't go through the two functions
>    touched in this patch.
> 4. shadow_enable explicitly sets PGT_l2_page_table, but the allocation
>    and deallocation of such pages don't go through the two functions
>    touched in this patch.
> 
> Also move the declarations to pv/mm.h. The code will be moved later.
> Take the chance to change preemptible to bool.

I'm fine with the movement, but I'm not convinced each and every
function used by PV only needs to obtain a pv_ prefix. These is a
generic memory management helpers; it just so happens that they're
needed for PV only (the abuse of the PGT_l{1,2}_page_table types
you mention above would otherwise need to go away as well, as
those page types then also would need to become PV-only, including
their names).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel