Re: [Xen-devel] [PATCH] tools/xenstore: add libdl dependency to libxenstore

[Juergen Gross <jgross@xxxxxxxx>]

On 07/03/18 13:06, ian.jackson@xxxxxxxxxx wrote:
> Juergen Gross writes ("Re: [PATCH] tools/xenstore: add libdl dependency to 
> libxenstore"):
>> On 07/03/18 12:19, Ian Jackson wrote:
>>> Juergen Gross writes ("[PATCH] tools/xenstore: add libdl dependency to 
>>> libxenstore"):
>>>>  libxenstore.so.$(MAJOR).$(MINOR): LDFLAGS += -ldl
>>>> +else
>>>> +PKG_CONFIG_REMOVE += dl
>>>
>>> What is this ?
>>
>> -ldl is needed on Linux only, but I didn't want to add a Linux specific
>> pkg-config file. So I'm removing the dependency in case we are not on
>> Linux.
> 
> Sorry, I was grepping an older xen tree, so I didn't see where this
> variable was honoured.
> 
> Will this work, though, when what has to be done is to remove -ldl
> from Libs, rather than from Requires ?

Yes, I've tested it to work (in V2 we have: PKG_CONFIG_REMOVE += -ldl)


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel