Re: [Xen-devel] [PATCH v4 14/16] xen/grant: Switch common/grant_table.c to use typesafe MFN

[Julien Grall <julien.grall@xxxxxxx>]

Hi Jan,

On 02/03/18 15:54, Jan Beulich wrote:
> > > > On 21.02.18 at 15:02, <julien.grall@xxxxxxx> wrote:
> > @@ -872,7 +879,7 @@ map_grant_ref(
> >       struct grant_table *lgt, *rgt;
> >       struct vcpu   *led;
> >       grant_handle_t handle;
> > -    unsigned long  frame = 0;
> > +    mfn_t frame = _mfn(0);
> If the initializer is needed at all, I think it should again become
> INVALID_MFN. Same in a few other places.
I didn't switch to INVALID_MFN because I wasn't sure if some place in 
the code where relying on 0. If you think it is fine, then I am more 
thank happy to switch to INVALID_MFN.
> > --- a/xen/include/asm-x86/grant_table.h
> > +++ b/xen/include/asm-x86/grant_table.h
> > @@ -76,7 +76,7 @@ static inline unsigned int gnttab_dom0_max(void)
> >   #define gnttab_status_gmfn(d, t, i)                     \
> >       (mfn_to_gmfn(d, gnttab_status_mfn(t, i)))
> >   
> > -#define gnttab_mark_dirty(d, f) paging_mark_dirty((d), _mfn(f))
> > +#define gnttab_mark_dirty(d, f) paging_mark_dirty((d), f)
> Please take the opportunity and also drop the stray parentheses
> around d.
Sure.

> With these taken care of and with Wei's R-b
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel