Re: [Xen-devel] [RFC PATCH 45/49] ARM: new VGIC: vgic-init: implement vgic_init

[Julien Grall <julien.grall@xxxxxxx>]

On 19/02/18 15:53, Andre Przywara wrote:
> Hi,
>
> On 19/02/18 13:21, Julien Grall wrote:
> > Hi,
> >
> > On 09/02/18 14:39, Andre Przywara wrote:
> > > This patch allocates and initializes the data structures used to model
> > > the vgic distributor and virtual cpu interfaces. At that stage the
> > > number of IRQs and number of virtual CPUs is frozen.
> > >
> > > This is based on Linux commit ad275b8bb1e6, written by Eric Auger.
> > >
> > > Signed-off-by: Andre Przywara <andre.przywara@xxxxxxxxxx>
> > > ---
> > >    xen/arch/arm/vgic/vgic-init.c | 197
> > > ++++++++++++++++++++++++++++++++++++++++++
> > This file is exporting a lot of function, all the corresponding
> > prototype should be declared within this patch as well.
> But those are implementations of functions used by Xen code already, and
> are all declared in xen/include/asm-arm/vgic.h.
> Or did I miss any?
Hmmm no. Can you mention it in the commit message please?

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel